Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pprof support config host #5601

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

zedongh
Copy link
Contributor

@zedongh zedongh commented Jan 18, 2024

What changed?
Config on PProf support host

Why?
For container users, default localhost make outside access pprof api impossible, need to bind to 0.0.0.0.

How did you test it?
Local

Potential risks
No. if not config host default localhost same to previous state.

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2024

CLA assistant check
All committers have signed the CLA.

common/config/pprof.go Outdated Show resolved Hide resolved
common/config/pprof.go Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 26, 2024

Pull Request Test Coverage Report for Build 018db380-9b8e-4456-8a0c-cd613e006de3

Details

  • 0 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 59 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.004%) to 62.747%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/task/transfer_standby_task_executor.go 2 87.42%
service/history/task/fetcher.go 3 86.6%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 4 76.09%
common/persistence/nosql/nosql_task_store.go 5 61.95%
common/persistence/nosql/utils.go 8 12.0%
common/persistence/nosql/nosqlplugin/cassandra/db.go 9 47.06%
common/persistence/nosql/nosqlplugin/cassandra/gocql/public/client.go 12 20.93%
service/history/execution/mutable_state_task_refresher.go 14 59.81%
Totals Coverage Status
Change from base Build 018db357-5efb-4a37-b4cc-9d5d5ac6482b: 0.004%
Covered Lines: 92631
Relevant Lines: 147626

💛 - Coveralls

@Shaddoll Shaddoll enabled auto-merge (squash) February 16, 2024 19:59
@Shaddoll Shaddoll merged commit 20598ca into cadence-workflow:master Feb 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants