Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added three dynamic config properties #5602

Merged

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Jan 18, 2024

What changed?
Added three Dynamic config options for the workflow specific IDs project,

  • WorkflowIDCacheEnabled to enable/disable the wf cache,
  • WorkflowIDExternalRPS and WorkflowIDInternalRPS, for controlling the allowed RPS of internal and external calls

I set the default values to their most permissive so we can slowly onboard in the beginning

Why?
This is a part of ratelimiting too many requests to specific workflow IDs. We need WorkflowIDCacheEnabled as a safety to be able to easily disable the cache in case it causes issues.
The two RPS values should be configurable so we can slowly onboard the different domains.

How did you test it?
Tested locally with the file system client

Potential risks
No risk just adding the properties

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Jan 18, 2024

Pull Request Test Coverage Report for Build 018d213e-e938-43b4-b90d-048e72f436c3

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 62.633%

Totals Coverage Status
Change from base Build 018d20e9-56f9-4f4d-92f6-a6e61407071c: -0.008%
Covered Lines: 91605
Relevant Lines: 146256

💛 - Coveralls

@jakobht jakobht merged commit ababd93 into cadence-workflow:master Jan 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants