Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a stale workflow check to the taskvalidator and code cleanup. #5604

Merged
merged 11 commits into from
Jan 21, 2024

Conversation

agautam478
Copy link
Contributor

@agautam478 agautam478 commented Jan 18, 2024

What changed?

  • Added a stale workflow check to the task validator.
  • Added a delete workflow call if the workflow domain is deprecated or if the workflow is stale.
  • Removed the call to task validator from the history layer as the plan is now to put it in the execution layer.

Upon detecting an error during the update process, the function call will be placed in the execution context to cover all workflow execution scenarios, ensuring a thorough and efficient approach to identifying and resolving corruption across the system.

Why?
These changes were made to complete the taskvalidation service and call in the correct place in future.
With the addition of this final check the core service can be considered ready an usable. We can move forwarding with calling the taskvalidation step in the next PR.

How did you test it?
Uni tests.

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 marked this pull request as draft January 18, 2024 20:24
@agautam478 agautam478 changed the title Adding a stale workflow check to the taskvalidator. WIP: Adding a stale workflow check to the taskvalidator. Jan 18, 2024
@coveralls
Copy link

coveralls commented Jan 18, 2024

Pull Request Test Coverage Report for Build 018d2472-eae9-449d-a842-99d05034a694

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 62.703%

Totals Coverage Status
Change from base Build 018d2433-b5c1-4c3d-8a22-6b4c48143927: 0.03%
Covered Lines: 91881
Relevant Lines: 146534

💛 - Coveralls

@agautam478 agautam478 marked this pull request as ready for review January 18, 2024 23:21
@agautam478 agautam478 changed the title WIP: Adding a stale workflow check to the taskvalidator. Adding a stale workflow check to the taskvalidator and code cleanup. Jan 18, 2024
common/constants.go Show resolved Hide resolved
common/taskvalidator/validateworkflow.go Outdated Show resolved Hide resolved
common/taskvalidator/validateworkflow.go Outdated Show resolved Hide resolved
@agautam478 agautam478 merged commit 8a5d203 into cadence-workflow:master Jan 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants