-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a stale workflow check to the taskvalidator and code cleanup. #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the execution layer
agautam478
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
January 18, 2024 19:15
agautam478
changed the title
Adding a stale workflow check to the taskvalidator.
WIP: Adding a stale workflow check to the taskvalidator.
Jan 18, 2024
Pull Request Test Coverage Report for Build 018d2472-eae9-449d-a842-99d05034a694
💛 - Coveralls |
agautam478
changed the title
WIP: Adding a stale workflow check to the taskvalidator.
Adding a stale workflow check to the taskvalidator and code cleanup.
Jan 18, 2024
allenchen2244
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Upon detecting an error during the update process, the function call will be placed in the
execution
context to cover all workflow execution scenarios, ensuring a thorough and efficient approach to identifying and resolving corruption across the system.Why?
These changes were made to complete the taskvalidation service and call in the correct place in future.
With the addition of this final check the core service can be considered ready an usable. We can move forwarding with calling the
taskvalidation
step in the next PR.How did you test it?
Uni tests.
Potential risks
Release notes
Documentation Changes