add ContextKey Struct #5606
Merged
add ContextKey Struct #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxia
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018d23c8-fdc9-453f-b47e-97c444135c93
💛 - Coveralls |
…e into xbowen_add_ContextKey_Struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a struct ContextKey
Why?
This is for Pinot/ES response comparator usage:
In mono repo (Cadence-Operation) our workflow needs to query both Pinot and ES in the runtime. So we need to pass in a Context Key-Value (visibility-override = Primary/Secondary) pair to reach this goal. Context key can only be a struct, so we need to create one here in OSS so that both OSS and Mono repo can use it.
How did you test it?
It's just one struct, doesn't include any logics.
Potential risks
none
Release notes
Documentation Changes