Fixed lint errors introduced in previous PR #5613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
davidporter-id-au
approved these changes
Jan 22, 2024
davidporter-id-au
merged commit 6c56c4c
into
cadence-workflow:master
15 of 16 checks passed
davidporter-id-au
pushed a commit
that referenced
this pull request
Jan 22, 2024
What changed? Split the different runs into their own lines, so the whole script fails when one of them fails. Linting is expected to fail as the lint issues fixed in this PR #5613 is not merged yet Why? Currently the script will not fail even though the lint fails How did you test it? Tested locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed lint errors introduced in previous PR
Why?
The linter than runs when running
make binsdoes not pass, so currently it is not possible tomake binsHow did you test it?
Ran the linter and unit tests
Potential risks
Release notes
Documentation Changes