Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get/Update DomainAsyncWorkflowConfiguraton methods in admin API and CLI #5616

Merged

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Jan 23, 2024

What changed?
Continuing from where I left in #5608. Admin API methods GetDomainAsyncWorkflowConfiguraton and UpdateDomainAsyncWorkflowConfiguraton are implemented and corresponding CLI tool commands are exposed.

Next steps:

  • DB schema changes on DomainConfig type to make this work e2e
  • Complete changes in config.go.

How did you test it?

  • Unit and integration tests to validate nothing is broken
  • Tried new API via new CLI commands
    Get example:
go run cmd/tools/cli/main.go admin aq get \
  --domain samples-domain

Put example:

go run cmd/tools/cli/main.go admin aq update \
  --domain samples-domain \
  --json "{\"PredefinedQueueName\":\"yoyo\"}"

common/config/config.go Outdated Show resolved Hide resolved
@taylanisikdemir taylanisikdemir changed the title Get/Update DomainAsyncWorkflowConfiguraton implementations in admin API and CLI Get/Update DomainAsyncWorkflowConfiguraton methods in admin API and CLI Jan 23, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018d37ae-f5e4-4d01-82ee-559a6622e24c

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 62.631%

Totals Coverage Status
Change from base Build 018d3424-fd0e-4e77-9c17-3444e51d7d38: 0.02%
Covered Lines: 92018
Relevant Lines: 146920

💛 - Coveralls

@@ -58,8 +58,8 @@ func (s *cadenceSerializerSuite) SetupTest() {
s.Assertions = require.New(s.T())
}

// TODO: update tests to cover asyncworkflowconfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding the tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test body is not ideal. I will convert this to proper table test and simplify the body in a follow up PR

@taylanisikdemir taylanisikdemir merged commit 68706a6 into cadence-workflow:master Jan 23, 2024
16 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/async_wf_config branch January 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants