-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get/Update DomainAsyncWorkflowConfiguraton methods in admin API and CLI #5616
Merged
taylanisikdemir
merged 5 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/async_wf_config
Jan 23, 2024
Merged
Get/Update DomainAsyncWorkflowConfiguraton methods in admin API and CLI #5616
taylanisikdemir
merged 5 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/async_wf_config
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
reviewed
Jan 23, 2024
taylanisikdemir
changed the title
Get/Update DomainAsyncWorkflowConfiguraton implementations in admin API and CLI
Get/Update DomainAsyncWorkflowConfiguraton methods in admin API and CLI
Jan 23, 2024
taylanisikdemir
force-pushed
the
taylan/async_wf_config
branch
from
January 23, 2024 17:21
d61feae
to
344d97c
Compare
Pull Request Test Coverage Report for Build 018d37ae-f5e4-4d01-82ee-559a6622e24c
💛 - Coveralls |
taylanisikdemir
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
January 23, 2024 19:27
Shaddoll
reviewed
Jan 23, 2024
@@ -58,8 +58,8 @@ func (s *cadenceSerializerSuite) SetupTest() { | |||
s.Assertions = require.New(s.T()) | |||
} | |||
|
|||
// TODO: update tests to cover asyncworkflowconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test body is not ideal. I will convert this to proper table test and simplify the body in a follow up PR
Shaddoll
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Continuing from where I left in #5608. Admin API methods
GetDomainAsyncWorkflowConfiguraton
andUpdateDomainAsyncWorkflowConfiguraton
are implemented and corresponding CLI tool commands are exposed.Next steps:
How did you test it?
Get example:
Put example: