-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffold async workflow queue provider component #5627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
January 24, 2024 22:24
Shaddoll
force-pushed
the
asyncqueue
branch
7 times, most recently
from
January 25, 2024 23:46
03c44b9
to
9e202ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM. will take one final pass after UTs
Shaddoll
force-pushed
the
asyncqueue
branch
2 times, most recently
from
January 26, 2024 03:54
ef3b0cc
to
77d7c02
Compare
Shaddoll
changed the title
[WIP]Scaffold asyncqueue provider component
Scaffold async workflow queue provider component
Jan 26, 2024
davidporter-id-au
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hard to fault anything here
taylanisikdemir
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Async workflow queue config will looks like this:
Why?
This component is used by our async workflow API to publish async requests to a queue and consume the request with a controlled throughput. We implement a plugin system in the component to allow us change the implementation of the queue easily. Currently, we only support Kafka.
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes