-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a middleware for comparator to use #5637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxia
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
January 30, 2024 00:35
davidporter-id-au
approved these changes
Jan 30, 2024
Note: will not merge it until I test it is working |
oh, be sure to run the linter too |
davidporter-id-au
approved these changes
Jan 30, 2024
mantas-sidlauskas
pushed a commit
to mantas-sidlauskas/cadence
that referenced
this pull request
Jan 31, 2024
What changed? Add a middleware for comparator to use. Why? We need to receive the yarpc req sent from PinotResponseComparator, and then pass the cadence-visibility-override value into ctx. So that PinotVisibilityTripleManager can use it to switch between pinot and es. How did you test it? Will do manually testing. Potential risks Release notes Documentation Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add a middleware for comparator to use.
Why?
We need to receive the yarpc req sent from PinotResponseComparator, and then pass the cadence-visibility-override value into ctx. So that PinotVisibilityTripleManager can use it to switch between pinot and es.
How did you test it?
Will do manually testing.
Potential risks
Release notes
Documentation Changes