Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a middleware for comparator to use #5637

Merged
merged 8 commits into from
Jan 30, 2024

Conversation

bowenxia
Copy link
Contributor

What changed?
Add a middleware for comparator to use.

Why?
We need to receive the yarpc req sent from PinotResponseComparator, and then pass the cadence-visibility-override value into ctx. So that PinotVisibilityTripleManager can use it to switch between pinot and es.

How did you test it?
Will do manually testing.

Potential risks

Release notes

Documentation Changes

@bowenxia
Copy link
Contributor Author

Note: will not merge it until I test it is working

@davidporter-id-au
Copy link
Member

oh, be sure to run the linter too

@coveralls
Copy link

coveralls commented Jan 30, 2024

Pull Request Test Coverage Report for Build 018d5cb2-79ed-4537-b4df-9fb310e60bc2

  • -15 of 16 (6.25%) changed or added relevant lines in 3 files are covered.
  • 142 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.05%) to 62.7%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/pinotVisibilityTripleManager.go 0 4 0.0%
common/rpc/middleware.go 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/executionManager.go 2 78.94%
service/history/execution/mutable_state_util.go 2 37.63%
service/history/task/fetcher.go 2 85.57%
service/history/task/transfer_active_task_executor.go 2 72.35%
service/matching/taskListManager.go 2 80.2%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.55%
common/task/fifo_task_scheduler.go 3 84.54%
common/persistence/statsComputer.go 5 94.64%
service/history/task/transfer_standby_task_executor.go 6 86.6%
service/history/task/cross_cluster_task_processor.go 8 80.79%
Totals Coverage Status
Change from base Build 018d5b75-04d8-4a7f-a749-a07f0da8cb21: -0.05%
Covered Lines: 92254
Relevant Lines: 147135

💛 - Coveralls

@davidporter-id-au davidporter-id-au enabled auto-merge (squash) January 30, 2024 23:29
@davidporter-id-au davidporter-id-au merged commit 856a775 into master Jan 30, 2024
16 checks passed
@davidporter-id-au davidporter-id-au deleted the xbowen_PinotComparatorMiddleware branch January 30, 2024 23:49
mantas-sidlauskas pushed a commit to mantas-sidlauskas/cadence that referenced this pull request Jan 31, 2024
What changed?
Add a middleware for comparator to use.

Why?
We need to receive the yarpc req sent from PinotResponseComparator, and then pass the cadence-visibility-override value into ctx. So that PinotVisibilityTripleManager can use it to switch between pinot and es.

How did you test it?
Will do manually testing.

Potential risks

Release notes

Documentation Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants