Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ratelimiter needs to be created with the domain name not the ID #5644

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Feb 6, 2024

What changed?
The ratelimiter is per domain name not id, fixed this, so we can do the filtering correctly

Why?
Because we need to filter on the correct value

How did you test it?
Tested locally, and updated the unit tests

Potential risks

Release notes

Documentation Changes

Copy link
Member

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is misleading, the change is related to domain name, not workflow name.

service/history/workflowcache/cache.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 6, 2024

Pull Request Test Coverage Report for Build 018d82ea-383f-4199-ae33-947017e9ac08

  • 0 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 42 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.06%) to 62.68%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/shard/context.go 2 67.3%
service/history/task/fetcher.go 2 85.05%
service/history/task/transfer_standby_task_executor.go 2 87.42%
service/matching/taskListManager.go 2 80.2%
common/task/fifo_task_scheduler.go 4 85.57%
service/history/task/cross_cluster_task_processor.go 8 80.79%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018d81f4-86bd-4ce5-8d93-3956b0300fa6: 0.06%
Covered Lines: 92176
Relevant Lines: 147059

💛 - Coveralls

@jakobht jakobht changed the title The ratelimiter needs to be created with the workflow name not the ID The ratelimiter needs to be created with the domain name not the ID Feb 6, 2024
@jakobht
Copy link
Member Author

jakobht commented Feb 6, 2024

The name is misleading, the change is related to domain name, not workflow name.

Thanks for catching that - I have edited the title and description

@jakobht jakobht merged commit be20d12 into cadence-workflow:master Feb 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants