Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting wfCacheEnabled config for internal and external requests #5647

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

sankari165
Copy link
Member

@sankari165 sankari165 commented Feb 7, 2024

What changed?
WorkflowIDCacheEnabled config flag will be replaced by WorkflowIDCacheExternalEnabled and WorkflowIDCacheInternalEnabled

Why?
If the workflow cache is overwhelmed by one type of requests we can choose to enable/dsisable one of them without affecting the other

How did you test it?
unit tests

Potential risks
The cache is still not in use in production.

Release notes

Documentation Changes

@jakobht
Copy link
Member

jakobht commented Feb 7, 2024

Looks good, but I think it's fine to just delete the WorkflowIDCacheEnabled in this PR?

@coveralls
Copy link

coveralls commented Feb 8, 2024

Pull Request Test Coverage Report for Build 018d8802-68d8-4158-9f88-2ca50acfa851

  • 0 of 25 (100.0%) changed or added relevant lines in 3 files are covered.
  • 77 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.002%) to 62.698%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/fifo_task_scheduler.go 2 85.57%
common/util.go 2 91.69%
service/frontend/api/handler.go 2 61.78%
service/history/shard/context.go 2 67.3%
service/matching/taskListManager.go 2 80.2%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.1%
common/persistence/statsComputer.go 3 94.29%
Totals Coverage Status
Change from base Build 018d8705-8ae5-4d48-8ec4-68c8df4537e5: -0.002%
Covered Lines: 92247
Relevant Lines: 147128

💛 - Coveralls

common/dynamicconfig/constants.go Show resolved Hide resolved
service/history/workflowcache/cache_test.go Outdated Show resolved Hide resolved
service/history/workflowcache/cache_test.go Outdated Show resolved Hide resolved
@sankari165 sankari165 enabled auto-merge (squash) February 8, 2024 09:17
@sankari165 sankari165 merged commit 152ffa0 into cadence-workflow:master Feb 8, 2024
16 checks passed
@sankari165 sankari165 deleted the CDNC-6832 branch February 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants