Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async workflow request consumer manager in worker #5655

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Feb 12, 2024

What changed?
This PR adds implementation of async workflow request consumer manager which starts/stops consumers periodically based on domain configs.

How did you test it?
Added new unit tests. Integration tests will be added in follow up PRs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018d9f34-83b0-436c-b840-df2238cf7338

Details

  • -34 of 136 (75.0%) changed or added relevant lines in 3 files are covered.
  • 79 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.04%) to 62.743%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/worker/asyncworkflow/async_workflow_consumer_manager.go 101 107 94.39%
common/messaging/noop_consumer.go 0 10 0.0%
service/worker/service.go 1 19 5.26%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.23%
service/worker/service.go 1 23.99%
tools/cli/admin_db_decode_thrift.go 1 71.43%
common/cache/lru.go 2 92.89%
common/persistence/sql/common.go 2 72.73%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/fifo_task_scheduler.go 2 85.57%
Totals Coverage Status
Change from base Build 018d9ea7-643c-4361-9ed1-29c6bbb0c8b6: 0.04%
Covered Lines: 92513
Relevant Lines: 147447

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit 63ea286 into cadence-workflow:master Feb 12, 2024
16 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/worker_async_skeleton branch February 12, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants