Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SignalWithStartWorkflowExecutionAsync API #5657

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Implement SignalWithStartWorkflowExecutionAsync API

Why?
To support new feature

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018d9fa8-75f8-405b-9b1e-38f93e6b0a11

Details

  • -46 of 142 (67.61%) changed or added relevant lines in 5 files are covered.
  • 60 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.05%) to 62.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/frontend/client.go 0 6 0.0%
service/frontend/wrappers/metered/metered.go 0 8 0.0%
service/frontend/api/handler.go 48 80 60.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/fifo_task_scheduler.go 2 85.57%
common/util.go 2 91.69%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.1%
common/persistence/nosql/nosql_execution_store.go 9 60.98%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 20 79.13%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018d9f74-9e07-43d7-b5c0-4148e6f476a8: 0.05%
Covered Lines: 92596
Relevant Lines: 147569

💛 - Coveralls

Copy link
Member

@taylanisikdemir taylanisikdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you merge I'll update #5658 to support SignalWithStartWorkflowExecution

@Shaddoll Shaddoll merged commit a614c4c into cadence-workflow:master Feb 13, 2024
16 checks passed
@Shaddoll Shaddoll deleted the async-api branch February 13, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants