Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment in workflow id cache config #5661

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

sankari165
Copy link
Member

@sankari165 sankari165 commented Feb 14, 2024

What changed?
Comment fixed in workflow ID cache config

Why?
It was an error made while changing the flags

How did you test it?

Potential risks

Release notes

Documentation Changes

@sankari165 sankari165 merged commit 373aacd into cadence-workflow:master Feb 14, 2024
16 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018da804-0a6c-4359-b260-bf972155cff8

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 80 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 62.787%

Files with Coverage Reduction New Missed Lines %
common/membership/hashring.go 2 84.05%
common/task/fifo_task_scheduler.go 2 85.57%
service/history/execution/mutable_state_util.go 2 37.63%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.55%
service/history/task/transfer_standby_task_executor.go 4 86.6%
service/history/task/fetcher.go 5 85.57%
service/history/task/cross_cluster_task_processor.go 8 80.79%
service/history/execution/mutable_state_task_refresher.go 14 63.61%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 20 83.06%
common/persistence/sql/workflowStateMaps.go 20 83.62%
Totals Coverage Status
Change from base Build 018da5f3-3627-4ce7-a640-1301a5169ce8: 0.02%
Covered Lines: 92613
Relevant Lines: 147503

💛 - Coveralls

@sankari165 sankari165 deleted the fix-comment branch February 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants