-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker compose setup for async workflows with kafka queue #5663
Merged
taylanisikdemir
merged 2 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/async_wf_kafka_docker_compose
Feb 15, 2024
Merged
Docker compose setup for async workflows with kafka queue #5663
taylanisikdemir
merged 2 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/async_wf_kafka_docker_compose
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
February 15, 2024 03:28
taylanisikdemir
changed the title
Docker compose setup for async workflow kafka queue
Docker compose setup for async workflows with kafka queue
Feb 15, 2024
Pull Request Test Coverage Report for Build 018daecf-4877-4be3-b0f0-e7bb2b04844eDetails
💛 - Coveralls |
taylanisikdemir
force-pushed
the
taylan/async_wf_kafka_docker_compose
branch
from
February 15, 2024 19:09
080a46d
to
91d655b
Compare
taylanisikdemir
force-pushed
the
taylan/async_wf_kafka_docker_compose
branch
from
February 15, 2024 22:07
91d655b
to
391f07d
Compare
Shaddoll
reviewed
Feb 15, 2024
shijiesheng
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested
root@74af085dad6c:/# $KAFKA_HOME/bin/kafka-topics.sh --describe --topic async-wf-topic1 --zookeeper zookeeper:2181
Topic:async-wf-topic1 PartitionCount:10 ReplicationFactor:1 Configs:
Topic: async-wf-topic1 Partition: 0 Leader: 1001 Replicas: 1001 Isr: 1001
Topic: async-wf-topic1 Partition: 1 Leader: 1001 Replicas: 1001 Isr: 1001
Topic: async-wf-topic1 Partition: 2 Leader: 1001 Replicas: 1001 Isr: 1001
Topic: async-wf-topic1 Partition: 3 Leader: 1001 Replicas: 1001 Isr: 1001
Topic: async-wf-topic1 Partition: 4 Leader: 1001 Replicas: 1001 Isr: 1001
Topic: async-wf-topic1 Partition: 5 Leader: 1001 Replicas: 1001 Isr: 1001
Topic: async-wf-topic1 Partition: 6 Leader: 1001 Replicas: 1001 Isr: 1001
Topic: async-wf-topic1 Partition: 7 Leader: 1001 Replicas: 1001 Isr: 1001
Topic: async-wf-topic1 Partition: 8 Leader: 1001 Replicas: 1001 Isr: 1001
Topic: async-wf-topic1 Partition: 9 Leader: 1001 Replicas: 1001 Isr: 1001
Also another possible optimization is to add another kafka setup image like this stack suggests to avoid a bigger additional cadence server image.
https://stackoverflow.com/questions/47615751/docker-compose-run-a-script-after-container-has-started
shijiesheng
approved these changes
Feb 15, 2024
shijiesheng
reviewed
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
asyncWorkflowQueues
section. Only enabled by the new docker compose file via an env var.kafka-topics.sh
to check during startup for now. The new image is tagged asubercadence/server:master-auto-setup-with-kafka
.Why?
This setup will be handy to try async workflows locally and also to setup CI integration test.
How did you test it?
Ran
docker-compose -f docker/docker-compose-async-wf-kafka.yml up
and validated all containers up and running. Verified the topic is created.A follow up PR will validate async workflows working e2e.