Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pinto query validator failed log, minor refactor pinot visibility store to remove panics #5664

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

neil-xie
Copy link
Member

What changed?
Update Pinto query validator failed log to include more details
Refactor pinot visibility store code to remove panics

Why?

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Feb 15, 2024

Pull Request Test Coverage Report for Build 018dae76-e956-4174-8ebe-895cefe2ba98

Details

  • -56 of 77 (27.27%) changed or added relevant lines in 2 files are covered.
  • 38 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.03%) to 62.74%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/pinot/pinotQueryValidator.go 4 9 44.44%
common/persistence/pinot/pinotVisibilityStore.go 17 68 25.0%
Files with Coverage Reduction New Missed Lines %
common/task/parallel_task_processor.go 2 93.06%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
service/history/shard/context.go 2 66.52%
service/matching/matcher.go 2 90.72%
service/matching/taskReader.go 2 84.88%
service/history/queue/timer_gate.go 3 95.83%
service/history/queue/timer_queue_processor_base.go 3 77.82%
common/persistence/pinot/pinotVisibilityStore.go 5 38.21%
service/history/execution/mutable_state_task_refresher.go 17 61.71%
Totals Coverage Status
Change from base Build 018dacf0-c704-41a4-9d3b-b82276de1999: 0.03%
Covered Lines: 92618
Relevant Lines: 147622

💛 - Coveralls

common/persistence/pinot/pinotVisibilityStore.go Outdated Show resolved Hide resolved
common/persistence/pinot/pinotVisibilityStore.go Outdated Show resolved Hide resolved
common/persistence/pinot/pinotVisibilityStore.go Outdated Show resolved Hide resolved
common/persistence/pinot/pinotVisibilityStore.go Outdated Show resolved Hide resolved
common/persistence/pinot/pinotVisibilityStore.go Outdated Show resolved Hide resolved
common/pinot/pinotQueryValidator.go Outdated Show resolved Hide resolved
@neil-xie neil-xie merged commit 9c26651 into cadence-workflow:master Feb 15, 2024
16 checks passed
@neil-xie neil-xie deleted the CDNC_7453 branch February 15, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants