Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing IsolationGroups field in domain cache entry #5679

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Feb 21, 2024

What changed?

DomainCache duplicates the entries before returning. It was missing IsolationGroups field.

TODO: This was identified while working on #5678 but sending as separate PR. Will rebase once the other one is merged.

Why?
To make sure the entries returned by domain cache is complete.

How did you test it?
unit tests

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018dcd3f-55f1-43f8-951b-3bdeb4fcc924

Details

  • -49 of 147 (66.67%) changed or added relevant lines in 10 files are covered.
  • 43 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.04%) to 62.777%

Changes Missing Coverage Covered Lines Changed/Added Lines %
host/dynamicconfig.go 2 4 50.0%
service/worker/asyncworkflow/async_workflow_consumer_manager.go 5 9 55.56%
host/integrationbase.go 0 5 0.0%
common/cache/domainCache.go 22 28 78.57%
host/onebox.go 22 54 40.74%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/matcher.go 2 90.72%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.1%
service/history/task/fetcher.go 3 85.57%
service/frontend/wrappers/metered/metered.go 4 65.5%
service/history/task/transfer_standby_task_executor.go 4 87.01%
service/matching/taskListManager.go 5 79.7%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 20 79.13%
Totals Coverage Status
Change from base Build 018dcce8-df73-46fe-8ff7-2acba6a12910: 0.04%
Covered Lines: 92768
Relevant Lines: 147774

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit d7479ca into cadence-workflow:master Feb 21, 2024
16 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/add_missing_isolation_conf_field branch February 21, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants