Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close status parse method in pinot query validator #5680

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

neil-xie
Copy link
Member

What changed?
Add close status parse method in pinot query validator, user can pass raw status string in listworkflowexecution endpoint

Why?

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018dce01-363c-4885-9c63-1178e9aa3435

Details

  • -4 of 26 (84.62%) changed or added relevant lines in 1 file are covered.
  • 76 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 62.782%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/pinot/pinotQueryValidator.go 22 26 84.62%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/task/parallel_task_processor.go 2 93.06%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/history/task/transfer_standby_task_executor.go 2 86.19%
common/persistence/statsComputer.go 3 94.64%
common/task/fifo_task_scheduler.go 7 80.41%
service/history/execution/mutable_state_task_refresher.go 16 62.03%
service/history/task/task_util.go 20 70.57%
common/persistence/sql/workflowStateMaps.go 23 81.25%
Totals Coverage Status
Change from base Build 018dcde8-cc05-4f3c-8cd9-a9a94a2bc97c: 0.02%
Covered Lines: 92792
Relevant Lines: 147800

💛 - Coveralls

@neil-xie neil-xie merged commit aab0c0a into cadence-workflow:master Feb 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants