Do not get workflow execution from database when shard is closed #5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018dfb02-1f63-4e69-abf8-09bb457166a4Details
💛 - Coveralls |
3vilhamster
approved these changes
Mar 1, 2024
| request *persistence.GetWorkflowExecutionRequest, | ||
| ) (*persistence.GetWorkflowExecutionResponse, error) { | ||
| if s.isClosed() { | ||
| return nil, ErrShardClosed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Do not get workflow execution from database when shard is closed
Why?
When a shard is closed, we should stop all the operations to the database from that shard. Read operation was allowed because it is safe. But since we do a checksum validation after GetWorkflowExecution from database, a false negative result might be returned from the validation if we allow reading data after a shard is closed.
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes