Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of tests for ArchivalConfigStateMachine in common/domain #5698

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

abhishekj720
Copy link
Contributor

This update introduces a comprehensive suite of unit tests for the getNextState method in the domain archival configuration state machine, enhancing coverage for various state transitions and validation logic.

It covers scenarios including enabling/disabling archival with valid/invalid URIs, immutability of URIs once set, and error handling for invalid states and events.

Addition of test files for increasing the coverage and to future self to not break any change while coding something in domain folder.

Added unit tests

No potential risks.

@coveralls
Copy link

coveralls commented Mar 1, 2024

Pull Request Test Coverage Report for Build 018dfb75-3236-43d2-814d-fb04d5645d28

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 77 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.02%) to 62.917%

Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 64.56%
service/matching/taskGC.go 1 97.37%
common/membership/hashring.go 2 82.23%
common/persistence/persistenceMetricClients.go 2 58.41%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/frontend/api/handler.go 2 62.05%
service/history/task/fetcher.go 2 85.57%
service/matching/matcher.go 2 90.72%
service/matching/taskListManager.go 2 79.7%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 61.93%
Totals Coverage Status
Change from base Build 018dfb1b-c20b-4820-815a-b6aed230920a: 0.02%
Covered Lines: 92998
Relevant Lines: 147811

💛 - Coveralls

@abhishekj720 abhishekj720 enabled auto-merge (squash) March 1, 2024 19:45
@abhishekj720 abhishekj720 merged commit 7fddc89 into cadence-workflow:master Mar 1, 2024
15 of 17 checks passed
@abhishekj720 abhishekj720 deleted the testArchivalSt branch March 1, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants