Test: Validate domain config test for attrValidator #5699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR introduces enhanced unit tests for
attrValidator.go
in theuber/cadence/common/domain
package, focusing on increasing test coverage through comprehensive, table-driven tests. It covers a range of scenarios including edge cases and error conditions for domain attribute validation functions.Why?: To improve code quality and reliability by ensuring all logical paths are tested, which helps in early detection of potential bugs and maintains high standards for the Cadence codebase.
How did you test it?: Tests were added and executed locally to verify their effectiveness. The coverage tool was used to ensure that the new tests significantly increase coverage for
attrValidator.go
.Potential risks: Minimal to none, as the changes are confined to unit tests which do not affect production code directly.
Release notes: Not applicable as the changes do not impact the functionality or schema.