Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Addition of tests for replicationQueue publish and publish to dlq #5700

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Addition of test for replication queue methods for publishing to DLQ. Includes several edge cases.

Why?
To make the code more secured, reliable and understandable. As well to increase test code coverage.

How did you test it?
unit tests

No potential risks as it contains only test cases.

@coveralls
Copy link

coveralls commented Mar 2, 2024

Pull Request Test Coverage Report for Build 018e0cd9-cc81-4cf1-a55b-92e5659fc501

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 82 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.02%) to 62.988%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/history/task/timer_task_executor_base.go 2 78.38%
service/matching/db.go 2 73.23%
common/log/tag/tags.go 3 50.18%
common/task/fifo_task_scheduler.go 3 84.54%
service/history/task/fetcher.go 3 85.57%
Totals Coverage Status
Change from base Build 018e0cd5-cd89-4f58-8adc-9436c21b4b6a: 0.02%
Covered Lines: 93099
Relevant Lines: 147804

💛 - Coveralls

common/domain/replication_queue_test.go Outdated Show resolved Hide resolved
common/domain/replication_queue_test.go Outdated Show resolved Hide resolved
@abhishekj720 abhishekj720 enabled auto-merge (squash) March 5, 2024 01:40
@abhishekj720 abhishekj720 merged commit 85d7147 into cadence-workflow:master Mar 5, 2024
17 checks passed
@abhishekj720 abhishekj720 deleted the testrq branch March 5, 2024 05:00
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
…lq (cadence-workflow#5700)

* Test: Addition of tests for replicationQueue publish and publish to dlq

* Creating mock for each test case and removing defer for finish controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants