Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for sql helper functions #5706

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Mar 4, 2024

What changed?
Add unit tests for sql helper functions

Why?
Improve test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll merged commit 6953daa into cadence-workflow:master Mar 4, 2024
16 of 17 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e0ac9-44c4-4e33-a66e-1fda34a34063

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 133 unchanged lines in 21 files lost coverage.
  • Overall coverage decreased (-0.05%) to 62.9%

Files with Coverage Reduction New Missed Lines %
common/membership/hashring.go 2 82.23%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/executionManager.go 2 78.59%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/fifo_task_scheduler.go 2 82.47%
service/history/task/transfer_standby_task_executor.go 2 87.01%
service/matching/db.go 2 73.23%
common/log/tag/tags.go 3 50.18%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 61.93%
Totals Coverage Status
Change from base Build 018e0aa0-f4cd-4828-ae2b-dcfbdcc1af74: -0.05%
Covered Lines: 92975
Relevant Lines: 147813

💛 - Coveralls

ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants