-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial codecov integration #5711
Merged
taylanisikdemir
merged 6 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/codecov
Mar 5, 2024
Merged
Initial codecov integration #5711
taylanisikdemir
merged 6 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/codecov
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 018e0fd6-4168-4905-9ce1-9efc2bbf8abaDetails
💛 - Coveralls |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
taylanisikdemir
force-pushed
the
taylan/codecov
branch
from
March 5, 2024 01:31
d7ed556
to
0d7eb06
Compare
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
March 5, 2024 01:31
Shaddoll
approved these changes
Mar 5, 2024
taylanisikdemir
force-pushed
the
taylan/codecov
branch
from
March 5, 2024 17:58
0d7eb06
to
f13f789
Compare
taylanisikdemir
force-pushed
the
taylan/codecov
branch
from
March 5, 2024 18:18
f13f789
to
34734a5
Compare
ketsiambaku
pushed a commit
to ketsiambaku/cadence
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding codecov github action to report coverage numbers. We will iterate on the configuration. For not it's supposed to be informational only and not blocking PRs.
Why?
We have coveralls integration but exploring codecov which is recommended by other Go OS teams in the org. Ideally we get accurate reporting and enforcements with this integration.
How did you test it?
PR checks trigger the github action that runs codecov. It's supposed to comment on the PR.