Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for CreateWorkflowExecution #5715

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Mar 5, 2024

What changed?
Add unit tests for CreateWorkflowExecution

Why?
Improve coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e0c58-8577-45de-8bcb-8cdfd4e82def

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • 45 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 63.013%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.23%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/parallel_task_processor.go 2 93.06%
service/matching/matcher.go 2 90.72%
common/persistence/statsComputer.go 3 94.64%
service/history/task/task_util.go 4 75.14%
service/history/task/transfer_standby_task_executor.go 4 86.6%
common/persistence/sql/workflowStateMaps.go 11 85.56%
service/history/execution/mutable_state_task_refresher.go 14 64.24%
Totals Coverage Status
Change from base Build 018e0bc4-bc99-45c7-b336-b5d3a2984942: 0.02%
Covered Lines: 93135
Relevant Lines: 147804

💛 - Coveralls

@Shaddoll Shaddoll merged commit fa9aad0 into cadence-workflow:master Mar 5, 2024
17 checks passed
@Shaddoll Shaddoll deleted the sql-test branch March 5, 2024 04:25
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants