Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old metrics wrappers and use new generated metered wrappers #5717

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

3vilhamster
Copy link
Member

What changed?
Switched to generated metered wrappers.
Previously, I've introduced metered wrappers for all persistence managers and verified that the behavior of these methods didn't change.
So it is safe to switch to them and remove the old untested file.

Why?
Improve test coverage and remove unused code.

How did you test it?
Unit tests to ensure that behaviour is the same between old metered clients and new one.

Potential risks
Logs/metrics could be affected, though with unit tests it is very unlikely.

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e0ef0-e611-45e8-b1fe-a587e7133718

Details

  • 10 of 11 (90.91%) changed or added relevant lines in 2 files are covered.
  • 65 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.1%) to 63.088%

Changes Missing Coverage Covered Lines Changed/Added Lines %
host/onebox.go 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
common/persistence/executionManager.go 2 78.59%
common/persistence/statsComputer.go 2 93.57%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/execution/mutable_state_util.go 2 37.63%
service/history/task/transfer_standby_task_executor.go 2 85.77%
service/matching/taskReader.go 2 84.88%
service/history/shard/context.go 9 66.84%
service/history/execution/context.go 14 68.05%
service/history/execution/mutable_state_task_refresher.go 14 62.34%
common/persistence/sql/sql_execution_store.go 16 79.15%
Totals Coverage Status
Change from base Build 018e0d82-79ea-4513-9f5b-be2bbdc6e60f: 0.1%
Covered Lines: 92530
Relevant Lines: 146667

💛 - Coveralls

@3vilhamster 3vilhamster merged commit 8bab585 into cadence-workflow:master Mar 5, 2024
17 checks passed
@3vilhamster 3vilhamster deleted the metrics-cleanp branch March 5, 2024 18:53
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
…adence-workflow#5717)

* remove old metrics wrappers and use new generated metered wrappers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants