Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for UpdateWorkflowExecution #5718

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Mar 5, 2024

What changed?

  • Add tests for UpdateWorkflowExecution
  • Remove code related to async transaction in UpdateWorkflowExecution because it's not needed (the code was never launched in production)

Why?
Improve test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@@ -482,24 +486,11 @@ func (m *sqlExecutionStore) updateWorkflowExecutionTx(
}
}

if m.useAsyncTransaction() { // async transaction is enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleanup

auto-merge was automatically disabled March 5, 2024 19:07

Pull Request is not mergeable

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 018e1016-92dc-4e10-8dd3-6e9adf24ad8e

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • 60 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.003%) to 63.101%

Files with Coverage Reduction New Missed Lines %
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/execution/mutable_state_util.go 2 37.63%
service/history/shard/context.go 2 66.67%
service/history/task/transfer_standby_task_executor.go 2 87.42%
common/persistence/sql/common.go 3 89.61%
common/persistence/sql/sqlplugin/mysql/db.go 3 79.49%
common/persistence/sql/sqlplugin/postgres/db.go 3 80.0%
service/history/task/transfer_active_task_executor.go 4 72.38%
common/persistence/sql/workflowStateMaps.go 8 81.25%
Totals Coverage Status
Change from base Build 018e0fff-ed52-48fd-a049-78d902657a34: -0.003%
Covered Lines: 92547
Relevant Lines: 146664

💛 - Coveralls

@Shaddoll Shaddoll enabled auto-merge (squash) March 5, 2024 19:28
@Shaddoll Shaddoll merged commit 08d84d1 into cadence-workflow:master Mar 5, 2024
18 checks passed
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants