Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for UpdateWorkflowEecution in nosql store-Part1 #5719

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

agautam478
Copy link
Contributor

@agautam478 agautam478 commented Mar 5, 2024

What changed?
Added test cases for UpdateWorkflowExecution in the nosql_store_test.go file.

Note: please, expect more test cases to come in the next PR.

Why?
As a part of increase the code coverage part

How did you test it?
Yes

Potential risks
NA

Release notes
NA

Documentation Changes

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 018e103f-584e-4901-b17b-ce660c1de1a8

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 105 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.05%) to 63.081%

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
common/membership/hashring.go 2 82.23%
common/persistence/historyManager.go 2 66.67%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/fifo_task_scheduler.go 2 87.63%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/util.go 2 91.69%
service/history/shard/context.go 2 66.67%
service/history/task/timer_task_executor_base.go 2 78.38%
Totals Coverage Status
Change from base Build 018e102c-68dc-4c76-87c7-72cf1ee0ffef: -0.05%
Covered Lines: 92517
Relevant Lines: 146664

💛 - Coveralls

@agautam478 agautam478 enabled auto-merge (squash) March 5, 2024 19:25
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #5719 (14ea768) into master (08d84d1) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 14ea768 differs from pull request most recent head 48f07b2. Consider uploading reports for the commit 48f07b2 to get more accurate results

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d84d1...48f07b2. Read the comment docs.

@agautam478 agautam478 merged commit bed1969 into cadence-workflow:master Mar 5, 2024
18 checks passed
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants