Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ConflictResolveWorkflowExecution #5721

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Mar 5, 2024

What changed?
Add unit tests for ConflictResolveWorkflowExecution

Why?
improve test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll merged commit 88cfab0 into cadence-workflow:master Mar 5, 2024
17 of 18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e105e-6bfd-4971-9f58-67ae49715b31

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 134 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.04%) to 63.133%

Files with Coverage Reduction New Missed Lines %
common/persistence/executionManager.go 2 78.59%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/statsComputer.go 2 94.64%
common/task/fifo_task_scheduler.go 2 85.57%
service/history/execution/mutable_state_builder.go 2 68.8%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 4 76.09%
common/persistence/nosql/nosql_task_store.go 5 61.95%
service/history/task/transfer_standby_task_executor.go 6 87.42%
common/persistence/nosql/nosql_execution_store.go 9 63.07%
Totals Coverage Status
Change from base Build 018e1052-01a3-4172-bdb6-43affa32f2d3: -0.04%
Covered Lines: 92594
Relevant Lines: 146665

💛 - Coveralls

@Shaddoll Shaddoll deleted the sql-test branch March 5, 2024 21:08
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants