Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two more test cases for the updateworkflowexecution #5722

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Added two more scenarios for the UpdateWorkflowExecution

Why?
To increase code coverage.

How did you test it?
Unit test

Potential risks
NA

Release notes
NA

Documentation Changes
NA

@agautam478 agautam478 enabled auto-merge (squash) March 5, 2024 20:52
@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 018e14d0-6976-4a40-ab40-93d5bdc641bf

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 64 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.05%) to 63.478%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/util.go 2 91.69%
service/frontend/api/handler.go 2 62.05%
service/history/queue/timer_gate.go 3 95.83%
common/archiver/filestore/historyArchiver.go 4 80.95%
common/task/fifo_task_scheduler.go 4 83.51%
service/history/execution/mutable_state_task_refresher.go 7 61.08%
service/frontend/wrappers/metered/metered.go 9 62.02%
common/persistence/sql/workflowStateMaps.go 12 83.62%
service/history/task/task_util.go 20 70.57%
Totals Coverage Status
Change from base Build 018e14cc-40de-489b-a510-e47441eda915: 0.05%
Covered Lines: 93112
Relevant Lines: 146684

💛 - Coveralls

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #5722 (d60507a) into master (45d755e) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head d60507a differs from pull request most recent head d5abc1d. Consider uploading reports for the commit d5abc1d to get more accurate results

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d755e...d5abc1d. Read the comment docs.

@agautam478 agautam478 merged commit 4451121 into cadence-workflow:master Mar 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants