Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for nosql_execution_Store_util.go - Part1 #5723

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Added a boilerplate setup for the nosql_execution_store_util.go

The test itself includes a success case for PrepareCreateWorkflowExecutionRequestWithMaps method.

Why?
to increase code coverage.

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 changed the title Added unit tests for nosql_execution_Store_util.go Added unit tests for nosql_execution_Store_util.go - Part1 Mar 5, 2024
@agautam478 agautam478 enabled auto-merge (squash) March 5, 2024 20:57
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #5723 (8a0f849) into master (768cb11) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 8a0f849 differs from pull request most recent head cabe46b. Consider uploading reports for the commit cabe46b to get more accurate results

Additional details and impacted files

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768cb11...cabe46b. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 018e114d-081a-40f4-87e1-a1ba8563a5d9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.03%) to 63.222%

Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 66.77%
common/persistence/historyManager.go 2 66.67%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/task/transfer_standby_task_executor.go 2 87.42%
service/history/queue/timer_gate.go 3 95.83%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/task/fetcher.go 6 85.05%
service/history/task/cross_cluster_task_processor.go 8 80.79%
Totals Coverage Status
Change from base Build 018e10f1-ea04-47e7-9f09-e8c4fb27206c: 0.03%
Covered Lines: 92736
Relevant Lines: 146683

💛 - Coveralls

@agautam478 agautam478 merged commit 55ff29b into cadence-workflow:master Mar 6, 2024
18 checks passed
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants