Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for CreateFailoverMarkerTasks #5724

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Mar 5, 2024

What changed?

  • Rewrite CreateFailoverMarkerTasks to batch insertions
  • Add unit tests for CreateFailoverMarkerTasks

Why?
Improve coverage and performance

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #5724 (c99c7f8) into master (50b4b84) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
common/persistence/sql/sql_execution_store.go 75.94% <100.00%> (+2.53%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b4b84...c99c7f8. Read the comment docs.

@Shaddoll Shaddoll merged commit 7de6d18 into cadence-workflow:master Mar 5, 2024
18 checks passed
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants