Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change noisy frontend poll timeout log to debug level #5725

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Mar 5, 2024

What changed?
Poll requests with timeout less than 20s causes a lot of noise in the logs. In total we see about 80% of the frontend logs is this single line: Context timeout is lower than critical value for long poll API.

There's not much value in keeping this as warning level so switching to debug level. Also adding domain name and task list tags to these logs

Why?
Reduce log noise.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #5725 (e3ca207) into master (50b4b84) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 60.00%.

Additional details and impacted files
Files Coverage Δ
common/util.go 77.94% <100.00%> (ø)
service/frontend/api/handler.go 38.46% <50.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de6d18...e3ca207. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 018e10d5-6a1f-4cd2-88e3-6e48230dc0e7

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 75 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.004%) to 63.219%

Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 38.1%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/execution/mutable_state_util.go 2 37.63%
service/history/handler/handler.go 2 49.59%
service/matching/taskReader.go 2 84.88%
common/persistence/statsComputer.go 3 94.64%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/task/fetcher.go 3 85.57%
service/frontend/api/handler.go 4 62.11%
service/history/task/transfer_standby_task_executor.go 4 86.19%
Totals Coverage Status
Change from base Build 018e10bf-df9b-47a4-889f-e9454573e538: 0.004%
Covered Lines: 92731
Relevant Lines: 146683

💛 - Coveralls

@taylanisikdemir taylanisikdemir force-pushed the taylan/frontend_noisy_logs branch 3 times, most recently from c71c892 to 2475169 Compare March 5, 2024 22:24
@taylanisikdemir taylanisikdemir enabled auto-merge (squash) March 5, 2024 22:24
@taylanisikdemir taylanisikdemir merged commit 768cb11 into cadence-workflow:master Mar 5, 2024
20 checks passed
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants