Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ES v6 client Search method #5727

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Mar 5, 2024

What changed?
Add unit test for Search method

Why?
Increase test coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #5727 (886a0fd) into master (71a196c) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a196c...886a0fd. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 018e12f0-6cf0-4300-9145-49f9d3156bd9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.04%) to 63.324%

Files with Coverage Reduction New Missed Lines %
common/membership/hashring.go 2 82.23%
common/persistence/historyManager.go 2 66.67%
service/history/execution/mutable_state_util.go 2 78.48%
service/history/shard/context.go 2 66.67%
service/matching/taskListManager.go 2 80.96%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 63.03%
service/history/task/fetcher.go 4 86.08%
service/history/task/transfer_standby_task_executor.go 4 85.77%
service/frontend/api/handler.go 5 62.23%
common/persistence/sql/workflowStateMaps.go 8 81.25%
Totals Coverage Status
Change from base Build 018e12b3-d0a9-4a57-9f85-00623526ab6b: 0.04%
Covered Lines: 92886
Relevant Lines: 146684

💛 - Coveralls

@neil-xie neil-xie enabled auto-merge (squash) March 6, 2024 08:46
@neil-xie neil-xie merged commit b443f02 into cadence-workflow:master Mar 6, 2024
20 checks passed
@neil-xie neil-xie deleted the CDNC_6987 branch March 6, 2024 09:19
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants