Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for TaskInfo types and utility functions #5732

Merged

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Mar 6, 2024

What changed?
Add more unit tests for several -info types and utility functions

Why?
Increase test coverage and stability of the platform

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@timl3136 timl3136 enabled auto-merge (squash) March 6, 2024 19:29
@coveralls
Copy link

coveralls commented Mar 6, 2024

Pull Request Test Coverage Report for Build 018e161f-684d-4394-8f80-44f5d3551d80

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 84 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 63.803%

Files with Coverage Reduction New Missed Lines %
common/task/fifo_task_scheduler.go 2 85.57%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/execution/mutable_state_builder.go 2 68.74%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/history/task/redispatcher.go 4 89.53%
service/history/task/task_util.go 4 75.14%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 63.03%
service/history/task/transfer_standby_task_executor.go 8 86.19%
service/history/execution/mutable_state_task_refresher.go 15 64.24%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 39 79.13%
Totals Coverage Status
Change from base Build 018e1613-5a84-4b9d-978a-cd89a943d096: 0.02%
Covered Lines: 93534
Relevant Lines: 146599

💛 - Coveralls

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

❗ No coverage uploaded for pull request base (master@3b5dc47). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 587a302 differs from pull request most recent head a836190. Consider uploading reports for the commit a836190 to get more accurate results

Additional details and impacted files

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5dc47...a836190. Read the comment docs.

@timl3136 timl3136 force-pushed the dataManagerInterfaces-test-4 branch from 587a302 to a836190 Compare March 6, 2024 23:35
@timl3136 timl3136 merged commit 65b45aa into cadence-workflow:master Mar 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants