Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Common/domain/replication_queue: GetMessagesfromDLQ & AckLevel #5734

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

abhishekj720
Copy link
Contributor

Why?:
Strengthening the test coverage for key components of the replication queue, specifically for retrieving messages from the DLQ and querying acknowledgment levels.

What has changed?:

Refined the GetMessagesFromDLQ test cases to validate successful message retrievals from DLQ, along with handling of read failures, ensuring the function behaves as expected in various scenarios.
Expanded the testing for GetAckLevel to cover successful acknowledgment level retrievals and to check the function's robustness against potential data retrieval issues.

How did you test it?:
unit tests with mock objects

Potential risks:
No risk involved.

common/domain/replication_queue_test.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #5734 (cb64a85) into master (9f4a87d) will decrease coverage by 0.32%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head cb64a85 differs from pull request most recent head 586caf0. Consider uploading reports for the commit 586caf0 to get more accurate results

Additional details and impacted files

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a43e3...586caf0. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 6, 2024

Pull Request Test Coverage Report for Build 018e156a-c04c-4289-8dac-a8b329c20f3b

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 80 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.004%) to 63.734%

Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 35.78%
common/membership/hashring.go 2 82.23%
common/persistence/executionManager.go 2 78.59%
common/persistence/historyManager.go 2 66.67%
common/persistence/statsComputer.go 2 93.57%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/execution/mutable_state_util.go 2 78.48%
service/history/handler/handler.go 2 49.59%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/taskReader.go 2 84.88%
Totals Coverage Status
Change from base Build 018e1568-e8c7-4b3e-b534-023ca39584ee: -0.004%
Covered Lines: 93434
Relevant Lines: 146599

💛 - Coveralls

@abhishekj720 abhishekj720 enabled auto-merge (squash) March 6, 2024 19:47
@abhishekj720 abhishekj720 merged commit f9acaea into cadence-workflow:master Mar 6, 2024
18 checks passed
@abhishekj720 abhishekj720 deleted the testrq3 branch March 6, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants