-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for GetWorkflowExecution #5736
Conversation
Codecov Report
Additional details and impacted filessee 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
}, | ||
}, | ||
mockSetup: func(db *sqlplugin.MockDB, parser *serialization.MockParser) { | ||
db.EXPECT().SelectFromExecutions(gomock.Any(), gomock.Any()).Return([]sqlplugin.ExecutionsRow{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be easier to use a mock sql like https://github.com/DATA-DOG/go-sqlmock rather than a gomocked entity.
Pull Request Test Coverage Report for Build 018e1699-1424-4592-bcbc-1234516091cbDetails
💛 - Coveralls |
What changed?
Add unit tests for GetWorkflowExecution
Why?
Improve test coverage
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes