Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests for nosql_execution_store.go #5738

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Added tests for the following:
ListConcreteExecutions, GetTransferTasks, and GetCrossClusterTasks

Added 1 success and one failure for each for now. The goal is to cover all functions in the file and then expand on the negative code paths.

Why?
As a part of code coverage initiative.

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@agautam478 agautam478 enabled auto-merge (squash) March 7, 2024 00:37
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5738 (3aeb018) into master (9526e4b) will decrease coverage by 0.40%.
The diff coverage is n/a.

❗ Current head 3aeb018 differs from pull request most recent head b9a72ac. Consider uploading reports for the commit b9a72ac to get more accurate results

Additional details and impacted files

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9526e4b...b9a72ac. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 018e1a15-ff02-4e36-9123-10876d595c5a

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 36 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.03%) to 63.913%

Files with Coverage Reduction New Missed Lines %
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifo_task_scheduler.go 2 82.47%
service/frontend/api/handler.go 2 62.17%
service/history/task/transfer_standby_task_executor.go 2 86.19%
service/matching/taskReader.go 2 84.88%
service/history/task/fetcher.go 4 86.08%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/matching/taskListManager.go 5 80.2%
service/frontend/wrappers/metered/metered.go 13 62.02%
Totals Coverage Status
Change from base Build 018e1771-8482-4aa6-97a2-9711c7cbdb6f: 0.03%
Covered Lines: 93696
Relevant Lines: 146599

💛 - Coveralls

@agautam478 agautam478 merged commit 50eedfa into cadence-workflow:master Mar 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants