Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more unit tests for ES v6 client #5739

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Mar 6, 2024

What changed?
Add unit tests for Scrolll, ClearScroll and IsNotFoundErr method

Why?
Increase test coverage

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@neil-xie neil-xie enabled auto-merge (squash) March 6, 2024 22:48
@neil-xie neil-xie merged commit 2d2ece0 into cadence-workflow:master Mar 6, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e15dd-b491-421c-8766-6b4cdb3af0f9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 85 unchanged lines in 21 files lost coverage.
  • Overall coverage decreased (-0.03%) to 63.731%

Files with Coverage Reduction New Missed Lines %
service/matching/matcher.go 1 91.07%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/executionManager.go 2 78.59%
common/persistence/historyManager.go 2 66.67%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/fifo_task_scheduler.go 2 85.57%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/util.go 2 91.69%
service/matching/db.go 2 73.23%
Totals Coverage Status
Change from base Build 018e15cf-3d6d-468c-b814-72a9a96fede3: -0.03%
Covered Lines: 93429
Relevant Lines: 146599

💛 - Coveralls

@neil-xie neil-xie deleted the CDNC_6987 branch March 6, 2024 23:22
@neil-xie neil-xie restored the CDNC_6987 branch March 7, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants