Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for common/domain: tests TestGetDLQSize, TestRangeDeleteMessagesFromDLQ and TestDeleteMessageFromDLQ #5741

Merged
merged 7 commits into from
Mar 7, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Wrote tests for:

  • TestRangeDeleteMessagesFromDLQ
  • TestDeleteMessageFromDLQ
  • TestGetDLQSize

Why?
Increase code coverage and better coding standards

How did you test it?
Unit tests

Potential risks
No risks as it only contains test with mock calls.

}
})
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add extra line with next ongoing PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR checks are failing. make fmt should take care

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #5741 (8822ab6) into master (65b45aa) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 8822ab6 differs from pull request most recent head 4c952ab. Consider uploading reports for the commit 4c952ab to get more accurate results

Additional details and impacted files

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b45aa...4c952ab. Read the comment docs.

}
})
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR checks are failing. make fmt should take care

@abhishekj720 abhishekj720 enabled auto-merge (squash) March 7, 2024 00:40
@abhishekj720 abhishekj720 merged commit 3da6ce9 into cadence-workflow:master Mar 7, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e1658-d902-4b3d-b1c8-0b4f1bb3a4ca

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 138 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.05%) to 63.771%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/persistence/historyManager.go 2 66.67%
common/task/fifo_task_scheduler.go 2 87.63%
service/history/execution/mutable_state_util.go 2 78.48%
service/history/task/fetcher.go 2 85.05%
service/history/task/transfer_standby_task_executor.go 2 86.19%
service/matching/taskReader.go 2 84.88%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/statsComputer.go 6 94.29%
Totals Coverage Status
Change from base Build 018e1631-7df5-41c4-aa3c-783fa88e3719: -0.05%
Covered Lines: 93488
Relevant Lines: 146599

💛 - Coveralls

@abhishekj720 abhishekj720 deleted the testrq6 branch March 7, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants