Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the util functions in data_manager_interface #5742

Merged

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Mar 6, 2024

What changed?
Add unit tests for the remaining uncovered unit tests in data_manager_interface file

Why?
Improve test coverage and stability

How did you test it?
Unit tests

Potential risks
Nothing since it's only unit tests

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #5742 (ef1239d) into master (83f9aca) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ef1239d differs from pull request most recent head 30cecf9. Consider uploading reports for the commit 30cecf9 to get more accurate results

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f9aca...30cecf9. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 6, 2024

Pull Request Test Coverage Report for Build 018e16ef-1ba4-443c-a82d-916cd06e3961

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.06%) to 63.91%

Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/fifo_task_scheduler.go 2 87.63%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/util.go 2 91.69%
service/history/task/fetcher.go 2 85.57%
service/matching/db.go 2 73.23%
service/matching/taskListManager.go 2 80.46%
common/log/tag/tags.go 3 50.18%
service/matching/taskReader.go 5 83.55%
Totals Coverage Status
Change from base Build 018e16ec-6c91-4f51-bb5b-51b534dddc09: 0.06%
Covered Lines: 93692
Relevant Lines: 146599

💛 - Coveralls

@timl3136 timl3136 enabled auto-merge (squash) March 7, 2024 00:30
@timl3136 timl3136 merged commit b34ee0b into cadence-workflow:master Mar 7, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants