Add error case tests for pinot_visibility_store #5746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxia
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
bowenxia
changed the title
taylanisikdemir
approved these changes
Mar 7, 2024
| @@ -604,7 +604,7 @@ func createVisibilityMessage( | |||
| for key, value := range rawSearchAttributes { | |||
| value, err = isTimeStruct(value) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, err // can't test because it's hard to create a scenario where this error happens | |||
There was a problem hiding this comment.
let's avoid adding these comments to actual code
| @@ -763,7 +763,7 @@ func (v *pinotVisibilityStore) getCountWorkflowExecutionsQuery(tableName string, | |||
| comparExpr, err := v.pinotQueryValidator.ValidateQuery(comparExpr) | |||
| if err != nil { | |||
| v.logger.Error(fmt.Sprintf("pinot query validator error: %s", err)) | |||
| } | |||
| } // can't test because it's hard to create a scenario where this error happens | |||
There was a problem hiding this comment.
we could mock some things inside ValidateQuery to mimic this failure but I don't think it's crucial
Codecov Report
Additional details and impacted filessee 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e165c-69ea-4fe2-bec4-e679416f98baDetails
💛 - Coveralls |
davidporter-id-au
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added more unit tests to test error cases
Why?
To reach a higher code coverage (~95%)
How did you test it?
unti test
Potential risks
Release notes
Documentation Changes