Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for util methods in es v6 client bulk processor #5748

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add unit test for util methods in es v6 client bulk processor #5748

merged 1 commit into from
Mar 7, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Mar 7, 2024

What changed?
Add unit test for util methods in es v6 client bulk processor
Fix a typo in fromV6ToGenericBulkResponse method name

Why?
Improve test coverage

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5748 (a57945d) into master (bc5cc93) will increase coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head a57945d differs from pull request most recent head 2dd7c76. Consider uploading reports for the commit 2dd7c76 to get more accurate results

Additional details and impacted files
Files Coverage Δ
common/elasticsearch/client/v6/client_bulk.go 37.16% <50.00%> (+37.16%) ⬆️

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5cc93...2dd7c76. Read the comment docs.

@neil-xie neil-xie enabled auto-merge (squash) March 7, 2024 01:40
@neil-xie neil-xie merged commit c41bd68 into cadence-workflow:master Mar 7, 2024
18 checks passed
@neil-xie neil-xie deleted the cdnc_6987_bulk branch March 7, 2024 01:51
@ibarrajo ibarrajo mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neil-xie @davidporter-id-au