Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for PurgeAckedMessages and replicationMessage in common/domain/replication_queue #5749

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Added tests for PurgeAckedMessages and replicationMessage

Why?
Test coverage

How did you test it?
Unit tests

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5749 (1e189b4) into master (da4cbf2) will increase coverage by 0.42%.
The diff coverage is n/a.

❗ Current head 1e189b4 differs from pull request most recent head 205708c. Consider uploading reports for the commit 205708c to get more accurate results

Additional details and impacted files

see 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da4cbf2...205708c. Read the comment docs.

@abhishekj720 abhishekj720 enabled auto-merge (squash) March 7, 2024 07:37
@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 018e1ed9-6164-4b36-9781-ebc61d76e3a9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 117 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.02%) to 63.68%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/task/transfer_active_task_executor.go 2 72.38%
common/persistence/historyManager.go 2 66.67%
client/history/client.go 2 35.78%
service/history/handler/handler.go 2 49.59%
common/util.go 2 91.69%
service/matching/taskListManager.go 3 80.2%
common/persistence/statsComputer.go 3 95.36%
service/frontend/api/handler.go 4 62.11%
service/history/task/transfer_standby_task_executor.go 4 86.6%
Totals Coverage Status
Change from base Build 018e1da2-2e13-4d90-9d75-822f85f1d078: 0.02%
Covered Lines: 93052
Relevant Lines: 146125

💛 - Coveralls

@abhishekj720 abhishekj720 merged commit 09c3743 into cadence-workflow:master Mar 8, 2024
18 checks passed
@abhishekj720 abhishekj720 deleted the testrq7 branch March 8, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants