Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for common/persistence/sql/factory.go #5751

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Mar 7, 2024

What changed?
Add unit tests for common/persistence/sql/factory.go

Why?
improve coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

❗ No coverage uploaded for pull request base (master@233b3ef). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 78029ab differs from pull request most recent head 4986dd7. Consider uploading reports for the commit 4986dd7 to get more accurate results

Additional details and impacted files

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 233b3ef...4986dd7. Read the comment docs.

@Shaddoll Shaddoll merged commit 82f08a8 into cadence-workflow:master Mar 7, 2024
18 checks passed
@Shaddoll Shaddoll deleted the sql-test branch March 7, 2024 21:20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e1ab5-db92-402f-9535-08ea18430888

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1104 unchanged lines in 22 files lost coverage.
  • Overall coverage decreased (-0.7%) to 63.215%

Files with Coverage Reduction New Missed Lines %
common/task/fifo_task_scheduler.go 2 85.57%
service/history/task/transfer_active_task_executor.go 2 72.51%
common/persistence/historyManager.go 2 66.67%
service/history/task/transfer_standby_task_executor.go 2 86.6%
common/util.go 2 91.69%
service/history/execution/mutable_state_util.go 2 78.48%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 71.41%
service/history/task/fetcher.go 3 85.57%
common/persistence/sql/workflow_state_non_maps.go 6 89.9%
common/persistence/sql/sql_config_store.go 12 53.85%
Totals Coverage Status
Change from base Build 018e1aa9-b112-4b5e-a137-732317ef6b1b: -0.7%
Covered Lines: 92672
Relevant Lines: 146599

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants