Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases for more util methods #5755

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

agautam478
Copy link
Contributor

What changed?
Added test cases for prepareReplicationTasksForWorkflowTxn,prepareNoSQLTasksForWorkflowTxn and prepareCrossClusterTasksForWorkflowTxn

Each contains one positive and one negative case.

The goal is to expand on the tests from this point. We are 50% through the file now.

Why?
To increase code coverage.

How did you test it?
Unit testing.

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5755 (dac3b95) into master (cdc3212) will increase coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head dac3b95 differs from pull request most recent head bf9de70. Consider uploading reports for the commit bf9de70 to get more accurate results

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b223d42...bf9de70. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 018e1b7c-de8f-40a6-9845-ba47b3454620

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 128 unchanged lines in 24 files lost coverage.
  • Overall coverage decreased (-0.006%) to 63.351%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
service/matching/db.go 2 73.23%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/taskListManager.go 2 79.7%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/common.go 2 46.75%
common/persistence/sql/sql_task_store.go 2 54.32%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
Totals Coverage Status
Change from base Build 018e1b7a-99f2-427e-9a3f-b3ed82a05b59: -0.006%
Covered Lines: 92872
Relevant Lines: 146598

💛 - Coveralls

@agautam478 agautam478 enabled auto-merge (squash) March 8, 2024 00:13
@agautam478 agautam478 merged commit 8c1eba8 into cadence-workflow:master Mar 8, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants