Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for es v6 bulk processor #5758

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Mar 7, 2024

What changed?
Added unit test for bulk processor start, close, stop, add, flush methods
Added unit test for run bulk processor

Why?
Test coverage

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@neil-xie neil-xie enabled auto-merge (squash) March 7, 2024 23:24
@neil-xie neil-xie merged commit d1e00cb into cadence-workflow:master Mar 7, 2024
17 of 18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e1b39-fd43-44ef-8b19-ba508c5e8d16

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 81 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 63.251%

Files with Coverage Reduction New Missed Lines %
common/task/fifo_task_scheduler.go 2 87.63%
service/history/task/transfer_active_task_executor.go 2 72.38%
common/persistence/statsComputer.go 2 95.71%
service/history/task/fetcher.go 2 85.05%
common/persistence/executionManager.go 2 78.59%
service/history/task/cross_cluster_task_processor.go 8 80.79%
service/history/shard/context.go 9 66.84%
service/history/execution/context.go 14 68.05%
common/persistence/sql/sql_execution_store.go 16 63.57%
service/history/task/task_util.go 24 69.43%
Totals Coverage Status
Change from base Build 018e1b39-db6b-450f-be5c-e6030346d786: 0.02%
Covered Lines: 92725
Relevant Lines: 146598

💛 - Coveralls

@neil-xie neil-xie deleted the cdnc_6987_bulk branch March 7, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants