Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for functions in gocql/batch.go #5759

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented Mar 7, 2024

What changed?
Add unit tests for functions in batch.go

Why?
Improve test coverage

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@timl3136 timl3136 enabled auto-merge (squash) March 7, 2024 21:58
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5759 (0f17107) into master (e198ca3) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e198ca3...0f17107. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e1af7-5255-4606-b624-61804f88844e

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 111 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.06%) to 63.211%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/fifo_task_scheduler.go 2 84.54%
service/matching/db.go 2 73.23%
service/history/task/transfer_active_task_executor.go 2 72.51%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/common.go 2 46.75%
common/persistence/sql/sql_task_store.go 2 54.32%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/executionManager.go 2 78.59%
service/history/queue/timer_gate.go 3 95.83%
Totals Coverage Status
Change from base Build 018e1af5-7c55-428d-9cce-978e3813e7da: -0.06%
Covered Lines: 92667
Relevant Lines: 146599

💛 - Coveralls

@timl3136 timl3136 merged commit 856145b into cadence-workflow:master Mar 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants