Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for ES v7 client #5760

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Mar 7, 2024

What changed?
Added unit test for ES v7 client, mostly same as v6 client unit test, modified a few paths that are changed in v7

Why?
Test coverage

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 018e1b52-0f43-45fb-b31c-94a0e8274350

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 69 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.07%) to 63.343%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/task/parallel_task_processor.go 2 93.06%
common/task/fifo_task_scheduler.go 2 87.63%
common/util.go 2 91.69%
common/persistence/statsComputer.go 3 94.64%
common/asyncworkflow/queue/consumer/default_consumer.go 3 92.05%
service/history/task/transfer_active_task_executor.go 4 72.38%
service/history/task/task_util.go 4 75.14%
service/history/task/fetcher.go 6 85.05%
service/history/task/cross_cluster_task_processor.go 8 80.79%
Totals Coverage Status
Change from base Build 018e1b4e-dbb0-43e9-bc0a-aeb699d11015: 0.07%
Covered Lines: 92859
Relevant Lines: 146598

💛 - Coveralls

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5760 (5c64bc1) into master (d1e00cb) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 5c64bc1 differs from pull request most recent head 5ed0f3e. Consider uploading reports for the commit 5ed0f3e to get more accurate results

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc3212...5ed0f3e. Read the comment docs.

@neil-xie neil-xie enabled auto-merge (squash) March 7, 2024 23:49
@neil-xie neil-xie merged commit b223d42 into cadence-workflow:master Mar 8, 2024
18 checks passed
@neil-xie neil-xie deleted the cdnc_6987_v7 branch March 8, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants