Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for es v7 bulk processor #5764

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Mar 8, 2024

What changed?
Add unit test for es v7 bulk processor
Change one method name to match naming conventions

Why?
Improve test coverage

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Mar 8, 2024

Pull Request Test Coverage Report for Build 018e1f33-f6cf-4769-a3e6-452c2d0b19ce

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 81 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.1%) to 63.911%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/elasticsearch/client/v7/client_bulk.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
common/elasticsearch/client/v7/client_bulk.go 1 92.19%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/task/transfer_active_task_executor.go 2 72.51%
service/matching/taskListManager.go 2 80.96%
service/history/task/transfer_standby_task_executor.go 2 87.42%
service/history/shard/context.go 2 66.67%
common/util.go 2 91.69%
service/history/execution/mutable_state_util.go 2 78.48%
common/membership/hashring.go 2 82.23%
service/history/queue/timer_gate.go 3 95.83%
Totals Coverage Status
Change from base Build 018e1f2e-cd91-4a89-a804-d5e16440a906: 0.1%
Covered Lines: 93166
Relevant Lines: 145774

💛 - Coveralls

@neil-xie neil-xie enabled auto-merge (squash) March 8, 2024 18:16
@neil-xie neil-xie merged commit a2e8540 into cadence-workflow:master Mar 8, 2024
17 of 18 checks passed
@neil-xie neil-xie deleted the cdnc_6987_v7_bulk branch March 8, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants