Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for open search client part 1 #5774

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

neil-xie
Copy link
Member

What changed?
Add unit test for open search client client, more to add
Simplified a test in ES client v6 and v7

Why?
Increase test coverage

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

}
}
}
assert.Equal(t, tt.expected, genericItems)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for simplifying this comparison

@neil-xie neil-xie enabled auto-merge (squash) March 11, 2024 17:21
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Merging #5774 (b0fca28) into master (ce25878) will decrease coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce25878...b0fca28. Read the comment docs.

@neil-xie neil-xie merged commit 9bd6ca2 into cadence-workflow:master Mar 11, 2024
20 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e2e98-332e-4440-bb83-3746605dfe34

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 107 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.003%) to 64.082%

Files with Coverage Reduction New Missed Lines %
service/history/task/timer_task_executor_base.go 2 78.38%
service/history/task/transfer_active_task_executor.go 2 72.51%
common/util.go 2 91.69%
service/matching/taskListManager.go 2 80.96%
common/task/fifo_task_scheduler.go 3 82.47%
common/persistence/statsComputer.go 3 94.64%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 4 76.09%
service/frontend/wrappers/metered/metered.go 4 65.5%
common/persistence/nosql/nosql_task_store.go 5 61.95%
common/persistence/nosql/nosqlplugin/cassandra/gocql/public/client.go 12 20.93%
Totals Coverage Status
Change from base Build 018e2e69-7db6-4e96-a90a-883272aa1a9f: -0.003%
Covered Lines: 93420
Relevant Lines: 145782

💛 - Coveralls

@neil-xie neil-xie deleted the cdnc_6987_os2 branch March 11, 2024 18:22
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request Mar 11, 2024
* Add unit tests for open search client

* Simplify tests in v6 and v7 client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants